Skip to content

[rush-client-core] Allow slow daemon startup in queued resend tests - #6160

Merged
Sean Larkin (TheLarkInn) merged 3 commits into
microsoft:mainfrom
TheLarkInn:user/selarkin/bot-rush-client-publish-timeout
Oct 21, 2026
Merged

Sean Larkin (TheLarkInn) merged 3 commits into
microsoft:mainfrom
TheLarkInn:user/selarkin/bot-rush-client-publish-timeout

Conversation

@TheLarkInn

@TheLarkInn Sean Larkin (TheLarkInn) commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Summary

Fix the Jest timeout blocking RushStack NPM Publish 12838.

Give the queued-request resend integration suite a 30-second default, matching the existing real-process test pattern. It starts and replaces real daemon processes; its 7-second per-start allowance already exceeds Jest's 5-second default. Existing assertions, explicit per-test timeouts and production behavior are unchanged.

Also fix the separate Windows/Node 24 check failure in the sequential RepoStateCache integration test. Its 14 state transitions launch 80 real Git processes inside one test. Give only this test 30 seconds, retaining every command and state comparison; package and repository defaults are unchanged.

How it was tested

  • Reproduced the exact queued-resend failure and 5,000 ms timeout by applying the fixture's existing 2,700 ms startup delay to both daemon starts.
  • With this change, the identical delayed-start test passed (8.857-second suite); the delay probe is not part of the patch.
  • All 12 queued-request resend tests passed with FORCE_COLOR=1 on Linux / Node 22.23.3.
  • All 182 package-deps-hash tests passed, including all 63 RepoStateCache tests.
  • With 100 ms added before each real Git launch, the sequential state test passed in 8.32 seconds using its actual per-test timeout, with all 80 Git commands completing successfully. The diagnostic injection is not part of the patch. This is a controlled Linux reproduction, not proof of a specific Windows runner cause.
  • Affected packages and dependency-closure build, including type checking and lint, passed. Rush change verification passed.

Required CI and human review remain required; no pipeline or policy retries were requested.

Give the real-process queued-request resend suite a 30-second default instead of Jest�4s 5 seconds. This fixes the timeout in RushStack NPM Publish 12838 without changing runtime deadlines, assertions, or explicit per-test bounds.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 196de551-3c6b-4904-ba03-e5c830ee0dbe
Add the required no-release change description for the queued-request resend integration test fix.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 196de551-3c6b-4904-ba03-e5c830ee0dbe
Give only the multi-command integration test a 30-second budget. Keep all state comparisons and production behavior unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 02159fef-9769-4d90-bd3d-7f1c7be585c9
@TheLarkInn
Sean Larkin (TheLarkInn) merged commit 37aec0a into microsoft:main Oct 21, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from Needs triage to Closed in Bug Triage Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

2 participants